Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: tests/test_suite_pem: Augment DES test cases with AES: PEM #7901

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Backport 2.28: tests/test_suite_pem: Augment DES test cases with AES: PEM #7901

merged 1 commit into from
Jul 10, 2023

Conversation

tgonzalezorlandoarm
Copy link
Contributor

Description

Backport #7879 that is in response to issue #7037 .

A few negative test cases in test_suite_pem.data rely on DES (“invalid iv”, “malformed”). DES is deprecated.
Construct similar test cases using AES and use them to remove the DES ones.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required
  • backport this is the backport
  • tests provided

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Jul 10, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm added enhancement needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jul 10, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm mentioned this pull request Jul 10, 2023
Merged
3 tasks
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as ready for review July 10, 2023 09:56
@tgonzalezorlandoarm tgonzalezorlandoarm added the needs-ci Needs to pass CI tests label Jul 10, 2023
@tgonzalezorlandoarm
tests/test_suite_pem: Augment DES test cases with AES: PEM
991c49f 
A few negative test cases in test_suite_pem.data rely on DES
(“invalid iv”, “malformed”). DES is deprecated.
Construct similar test cases using AES.

Signed-off-by: Tomás González <[email protected]>
gilles-peskine-arm
gilles-peskine-arm approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a simple backport of #7879

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review labels Jul 10, 2023
@gilles-peskine-arm gilles-peskine-arm merged commit 76a54ff into Mbed-TLS:mbedtls-2.28 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gilles-peskine-arm